From 9fd2f06a2c0fdd19b2cdae7d699b18e7d775940f Mon Sep 17 00:00:00 2001 From: Srinivas Kandagatla Date: Wed, 27 Sep 2023 13:22:24 +0100 Subject: [PATCH] ucm2: codecs: lpass-rx: use set Digital gain at 0dB For some reason we ended up with a Digital gain below 0dB, resulting in a very low HP volume. Fix this to 0dB and let Analog gain control HP volume. Also remove all redundant setting of this control. Closes: https://github.com/alsa-project/alsa-ucm-conf/pull/335 Signed-off-by: Srinivas Kandagatla Reviewed-by: Johan Hovold Tested-by: Johan Hovold Signed-off-by: Jaroslav Kysela --- ucm2/Qualcomm/sc8280xp/LENOVO-X13s.conf | 1 + ucm2/codecs/qcom-lpass/rx-macro/init.conf | 6 ++++++ ucm2/codecs/wcd938x/DefaultEnableSeq.conf | 2 -- ucm2/codecs/wcd938x/init.conf | 2 -- 4 files changed, 7 insertions(+), 4 deletions(-) create mode 100644 ucm2/codecs/qcom-lpass/rx-macro/init.conf diff --git a/ucm2/Qualcomm/sc8280xp/LENOVO-X13s.conf b/ucm2/Qualcomm/sc8280xp/LENOVO-X13s.conf index dd8f584..aea66d8 100644 --- a/ucm2/Qualcomm/sc8280xp/LENOVO-X13s.conf +++ b/ucm2/Qualcomm/sc8280xp/LENOVO-X13s.conf @@ -10,3 +10,4 @@ Include.ctl-remap.File "/lib/ctl-remap.conf" Include.codec-init.File "/codecs/wcd938x/init.conf" Include.codec-init.File "/codecs/wsa883x/init.conf" Include.codec-init.File "/codecs/qcom-lpass/wsa-macro/init.conf" +Include.codec-init.File "/codecs/qcom-lpass/rx-macro/init.conf" diff --git a/ucm2/codecs/qcom-lpass/rx-macro/init.conf b/ucm2/codecs/qcom-lpass/rx-macro/init.conf new file mode 100644 index 0000000..55b6927 --- /dev/null +++ b/ucm2/codecs/qcom-lpass/rx-macro/init.conf @@ -0,0 +1,6 @@ +# RX Digital codec specific volume control settings + +BootSequence [ + cset "name='RX_RX0 Digital Volume' 84" + cset "name='RX_RX1 Digital Volume' 84" +] diff --git a/ucm2/codecs/wcd938x/DefaultEnableSeq.conf b/ucm2/codecs/wcd938x/DefaultEnableSeq.conf index d283a5d..5da6717 100644 --- a/ucm2/codecs/wcd938x/DefaultEnableSeq.conf +++ b/ucm2/codecs/wcd938x/DefaultEnableSeq.conf @@ -1,6 +1,4 @@ EnableSequence [ - cset "name='RX_RX0 Digital Volume' 80" - cset "name='RX_RX1 Digital Volume' 80" cset "name='HPHR Volume' 20" cset "name='HPHL Volume' 20" ] diff --git a/ucm2/codecs/wcd938x/init.conf b/ucm2/codecs/wcd938x/init.conf index 3b7c119..c2a418c 100644 --- a/ucm2/codecs/wcd938x/init.conf +++ b/ucm2/codecs/wcd938x/init.conf @@ -1,8 +1,6 @@ # WCD938X specific volume control settings BootSequence [ - cset "name='RX_RX0 Digital Volume' 84" - cset "name='RX_RX1 Digital Volume' 84" cset "name='ADC2 Volume' 12" ] -- 2.47.1