From abc9f32cf45ccaf7a2f6674e5803aba6d4b5a7bf Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20Recoules?= Date: Wed, 6 May 2020 19:19:24 +0200 Subject: [PATCH] pcm: dmix: assembly: give more freedom over the constraints MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Minor changes that could help the compiler to produce a better (smaller/faster) code. Signed-off-by: Frédéric Recoules Signed-off-by: Takashi Iwai --- src/pcm/pcm_dmix_i386.h | 30 +++++++++++++++--------------- src/pcm/pcm_dmix_x86_64.h | 18 +++++++++--------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/pcm/pcm_dmix_i386.h b/src/pcm/pcm_dmix_i386.h index bd1d6644..8dcba3d8 100644 --- a/src/pcm/pcm_dmix_i386.h +++ b/src/pcm/pcm_dmix_i386.h @@ -149,13 +149,13 @@ static void MIX_AREAS_16(unsigned int size, #ifdef BOUNDED_EBX "\tmovl %[old_ebx], %%ebx\n" /* ebx is GOT pointer (-fPIC) */ #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_EBX , [old_ebx] "=m" (old_ebx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "esi", "edi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_EBX , "ebx" @@ -248,13 +248,13 @@ static void MIX_AREAS_16_MMX(unsigned int size, #ifdef BOUNDED_EBX "\tmovl %[old_ebx], %%ebx\n" /* ebx is GOT pointer (-fPIC) */ #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_EBX , [old_ebx] "=m" (old_ebx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "esi", "edi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_EBX , "ebx" @@ -376,13 +376,13 @@ static void MIX_AREAS_32(unsigned int size, #ifdef BOUNDED_EBX "\tmovl %[old_ebx], %%ebx\n" /* ebx is GOT pointer (-fPIC) */ #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_EBX , [old_ebx] "=m" (old_ebx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "esi", "edi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_EBX , "ebx" @@ -491,13 +491,13 @@ static void MIX_AREAS_24(unsigned int size, #ifdef BOUNDED_EBX "\tmovl %[old_ebx], %%ebx\n" /* ebx is GOT pointer (-fPIC) */ #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_EBX , [old_ebx] "=m" (old_ebx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "esi", "edi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_EBX , "ebx" @@ -599,13 +599,13 @@ static void MIX_AREAS_24_CMOV(unsigned int size, #ifdef BOUNDED_EBX "\tmovl %[old_ebx], %%ebx\n" /* ebx is GOT pointer (-fPIC) */ #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_EBX , [old_ebx] "=m" (old_ebx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "esi", "edi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_EBX , "ebx" diff --git a/src/pcm/pcm_dmix_x86_64.h b/src/pcm/pcm_dmix_x86_64.h index fff07529..aef5d90c 100644 --- a/src/pcm/pcm_dmix_x86_64.h +++ b/src/pcm/pcm_dmix_x86_64.h @@ -121,13 +121,13 @@ static void MIX_AREAS_16(unsigned int size, #ifdef BOUNDED_RBX "\tmovq %[old_rbx], %%rbx\n" #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_RBX , [old_rbx] "=m" (old_rbx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "rsi", "rdi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_RBX , "rbx" @@ -251,13 +251,13 @@ static void MIX_AREAS_32(unsigned int size, #ifdef BOUNDED_RBX "\tmovq %[old_rbx], %%rbx\n" #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_RBX , [old_rbx] "=m" (old_rbx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "rsi", "rdi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_RBX , "rbx" @@ -363,13 +363,13 @@ static void MIX_AREAS_24(unsigned int size, #ifdef BOUNDED_RBX "\tmovq %[old_rbx], %%rbx\n" #endif - : [size] "+m" (size) + : [size] "+&rm" (size) #ifdef BOUNDED_RBX , [old_rbx] "=m" (old_rbx) #endif : [dst] "m" (dst), [src] "m" (src), [sum] "m" (sum), - [dst_step] "m" (dst_step), [src_step] "m" (src_step), - [sum_step] "m" (sum_step) + [dst_step] "im" (dst_step), [src_step] "im" (src_step), + [sum_step] "im" (sum_step) : "rsi", "rdi", "edx", "ecx", "eax", "memory", "cc" #ifndef BOUNDED_RBX , "rbx" -- 2.47.1