From c04d7bbd6cbe7db23b2dc7fbbb11fd845f648a3c Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Mon, 11 May 2020 16:27:31 +0200 Subject: [PATCH] pcm: rate: Fix compile warning wrt bit ops and comparison MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We've got a gcc warning: pcm_rate.c: In function ‘snd_pcm_rate_drain’: pcm_rate.c:1090:19: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses] if (pcm->mode & SND_PCM_NONBLOCK != 0) { ^ Drop the zero comparison for fixing the warning and for simplicity. Fixes: 29041c522071 ("fix infinite draining of the rate plugin in SND_PCM_NONBLOCK mode") Signed-off-by: Takashi Iwai --- src/pcm/pcm_rate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pcm/pcm_rate.c b/src/pcm/pcm_rate.c index 4f99a95b..980fa44e 100644 --- a/src/pcm/pcm_rate.c +++ b/src/pcm/pcm_rate.c @@ -1087,7 +1087,7 @@ static int snd_pcm_rate_drain(snd_pcm_t *pcm) if (rate->last_commit_ptr >= pcm->boundary) rate->last_commit_ptr = 0; } else if (commit_err == 0) { - if (pcm->mode & SND_PCM_NONBLOCK != 0) { + if (pcm->mode & SND_PCM_NONBLOCK) { commit_err = -EAGAIN; break; } -- 2.47.1