From d71f294566e53c967a6a1e2d5c684499ec390d69 Mon Sep 17 00:00:00 2001 From: Clemens Ladisch Date: Sat, 18 Mar 2017 23:10:33 +0100 Subject: [PATCH] rawmidi: virtual: fix reading into a small buffer In the special case for handling partial messages, the pointer calculations were wrong, which would result in data corruption. Signed-off-by: Clemens Ladisch Reviewd-by: Takashi Sakamoto Signed-off-by: Takashi Iwai --- src/rawmidi/rawmidi_virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rawmidi/rawmidi_virt.c b/src/rawmidi/rawmidi_virt.c index e5b17e48..7daf3e16 100644 --- a/src/rawmidi/rawmidi_virt.c +++ b/src/rawmidi/rawmidi_virt.c @@ -263,8 +263,8 @@ static ssize_t snd_rawmidi_virtual_read(snd_rawmidi_t *rmidi, void *buffer, size } size1 = virt->in_buf_size - virt->in_buf_ofs; if ((size_t)size1 > size) { - virt->in_buf_ofs += size1 - size; - memcpy(buffer, virt->in_buf_ptr, size); + memcpy(buffer, virt->in_buf_ptr + virt->in_buf_ofs, size); + virt->in_buf_ofs += size; result += size; break; } -- 2.47.1