From dc1e683cc2d2aaed938f9459605d51d4a2cb7ba0 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Sat, 26 Aug 2023 21:21:13 +0200 Subject: [PATCH] seq: Fix wrong seq version update at snd_seq_hw_get_client_info() snd_seq_hw_get_client_info() calls mistakenly update_midi_version() that leads to the update of seq->version from another client info. It may lead to the inconsistent packet size calculation and the unaligned read, eventually a program may hit segfault. Drop the incorrect call of update_midi_version() for fixing it. Fixes: 2aefb5c41cc0 ("seq: Add UMP support") Closes: https://github.com/alsa-project/alsa-utils/issues/232 Signed-off-by: Takashi Iwai --- src/seq/seq_hw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/seq/seq_hw.c b/src/seq/seq_hw.c index 196de970..a51ebfb6 100644 --- a/src/seq/seq_hw.c +++ b/src/seq/seq_hw.c @@ -119,7 +119,6 @@ static int snd_seq_hw_get_client_info(snd_seq_t *seq, snd_seq_client_info_t * in info->card = -1; info->pid = -1; } - update_midi_version(seq, info); return 0; } -- 2.47.1