From f4746667a4a2490f17c2a82b6f421bc3c9bd6de8 Mon Sep 17 00:00:00 2001 From: Andre Guedes Date: Fri, 28 Sep 2018 14:27:25 -0700 Subject: [PATCH] jack: Fix leaks when jack_set_hw_constraint() fails If jack_set_hw_constraint() returns error, we leak the 'jack' object and all the resources referenced by it. This patch fixes the issue by calling snd_pcm_jack_free() before returning. Signed-off-by: Andre Guedes Reviewed-by: Takashi Sakamoto Signed-off-by: Takashi Iwai --- jack/pcm_jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c index b39835e..6aaecac 100644 --- a/jack/pcm_jack.c +++ b/jack/pcm_jack.c @@ -538,6 +538,7 @@ static int snd_pcm_jack_open(snd_pcm_t **pcmp, const char *name, err = jack_set_hw_constraint(jack); if (err < 0) { snd_pcm_ioplug_delete(&jack->io); + snd_pcm_jack_free(jack); return err; } -- 2.47.1