From fca62b83fbfee64479c8c5dcb30fe3f49bff6bd0 Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Sat, 4 Apr 2020 13:38:16 +0900 Subject: [PATCH] seq: event_data_ctl: change function signature to return nothing The alsa-gobject project has a loose convention to have functions returning nothing. Fixes: a8f603eff4f5: ("seq: event_data_ctl: add accessor methods") Signed-off-by: Takashi Sakamoto --- src/seq/event-data-ctl.c | 22 ++++++++++------------ src/seq/event-data-ctl.h | 7 ++++--- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/src/seq/event-data-ctl.c b/src/seq/event-data-ctl.c index 209d014..3e3a9f7 100644 --- a/src/seq/event-data-ctl.c +++ b/src/seq/event-data-ctl.c @@ -11,14 +11,14 @@ G_DEFINE_BOXED_TYPE(ALSASeqEventDataCtl, alsaseq_event_data_ctl, seq_event_data_ /** * alsaseq_event_data_ctl_get_channel: * @self: A #ALSASeqEventDataCtl. + * @channel: (out): The value of channel for the control event. * * Get the value of channel for the control event. - * - * Returns: the value of channel for the control event. */ -guint8 alsaseq_event_data_ctl_get_channel(ALSASeqEventDataCtl *self) +void alsaseq_event_data_ctl_get_channel(ALSASeqEventDataCtl *self, + guint8 *channel) { - return self->channel; + *channel = self->channel; } /** @@ -37,14 +37,13 @@ void alsaseq_event_data_ctl_set_channel(ALSASeqEventDataCtl *self, /** * alsaseq_event_data_ctl_get_param: * @self: A #ALSASeqEventDataCtl. + * @param: (out): The parameter for the control event. * * Get the parameter for the control event. - * - * Returns: the parameter for the control event. */ -guint alsaseq_event_data_ctl_get_param(ALSASeqEventDataCtl *self) +void alsaseq_event_data_ctl_get_param(ALSASeqEventDataCtl *self, guint *param) { - return self->param; + *param = self->param; } /** @@ -62,14 +61,13 @@ void alsaseq_event_data_ctl_set_param(ALSASeqEventDataCtl *self, guint param) /** * alsaseq_event_data_ctl_get_value: * @self: A #ALSASeqEventDataCtl. + * @value: (out): The value for the control event. * * Get the value for the control event. - * - * Returns: the value for the control event. */ -gint alsaseq_event_data_ctl_get_value(ALSASeqEventDataCtl *self) +void alsaseq_event_data_ctl_get_value(ALSASeqEventDataCtl *self, gint *value) { - return self->param; + *value = self->param; } /** diff --git a/src/seq/event-data-ctl.h b/src/seq/event-data-ctl.h index 50d60b6..0226029 100644 --- a/src/seq/event-data-ctl.h +++ b/src/seq/event-data-ctl.h @@ -17,14 +17,15 @@ typedef struct snd_seq_ev_ctrl ALSASeqEventDataCtl; GType alsaseq_event_data_ctl_get_type() G_GNUC_CONST; -guint8 alsaseq_event_data_ctl_get_channel(ALSASeqEventDataCtl *self); +void alsaseq_event_data_ctl_get_channel(ALSASeqEventDataCtl *self, + guint8 *channel); void alsaseq_event_data_ctl_set_channel(ALSASeqEventDataCtl *self, guint8 channel); -guint alsaseq_event_data_ctl_get_param(ALSASeqEventDataCtl *self); +void alsaseq_event_data_ctl_get_param(ALSASeqEventDataCtl *self, guint *param); void alsaseq_event_data_ctl_set_param(ALSASeqEventDataCtl *self, guint param); -gint alsaseq_event_data_ctl_get_value(ALSASeqEventDataCtl *self); +void alsaseq_event_data_ctl_get_value(ALSASeqEventDataCtl *self, gint *value); void alsaseq_event_data_ctl_set_value(ALSASeqEventDataCtl *self, gint value); G_END_DECLS -- 2.47.3